Refactor server lifecycle management #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephine-wolf-oberholtzer
force-pushed
the
server-lifecycle-events-take-2
branch
2 times, most recently
from
1cf5e6d to
2f55efe
Compare
josephine-wolf-oberholtzer
changed the title
josephine-wolf-oberholtzer
force-pushed
the
server-lifecycle-events-take-2
branch
from
2f55efe to
a80e736
Compare
josephine-wolf-oberholtzer
deleted the
server-lifecycle-events-take-2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a single dedicated function for managing the lifecycle of a server (sync or async), with the control flow in that function managed entirely by futures.
This guarantees that lifecycle event callbacks only execute inside that single lifecycle management function, allowing for async callbacks to be executed in order without needing to resort to spawning new tasks.
This also generally simplifies the server implementation(s), drastically reducing the complexity of callbacks between server, OSC protocol and process prototol.