Original and Modified models set earlier #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @StefanDBTLabs 👋 thanks for taking care of this. I'll release the new version tomorrow. |
suren-atoyan
approved these changes
Aug 22, 2023
|
done ✅ check |
|
thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These 2 hooks need to happen before Original (line 188) and Modified (line 100) are updated to make sure we are updating the right models. This fix is related to past pr #479
see existing editor still having the mode switching problem here: https://codesandbox.io/s/react-monaco-bug-vzgxt8?file=/src/App.js:888-1233