forked from facebook/react
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[DevTools] Enable pointEvents while scrolling (facebook#30560)
[`react-window` disables `pointerEvents` while scrolling meaning you can't click anything while scrolling.](bvaughn/react-window#128). This means that the first click when you stop the scroll with inertial scrolling doesn't get registered. This is suuuper annoying. This might make sense when you click to stop on a more intentional UI but it doesn't makes sense in a list like this because we eagerly click things even on mousedown. This PR just override that to re-enable pointer events. Supposedly this is done for performance but that might be outdated knowledge. I haven't observed any difference so far. If we discover that it's a perf problem, there's another technique we can use where we call `ownerDocument.elementFromPoint(e.pageX, e.pageY)` and then dispatch the event against that element. But let's try the simplest approach first? DiffTrain build for [06d0b89](facebook@06d0b89)
- Loading branch information
1 parent
c6c8ab9
commit 289e379
Showing
38 changed files
with
3,370 additions
and
5,055 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
41ecbada0e05f1dd40f8b94c6fa98dbdaabca211 | ||
06d0b89e8d6492d1c61bff3ae200dcc6b4809fed |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
41ecbada0e05f1dd40f8b94c6fa98dbdaabca211 | ||
06d0b89e8d6492d1c61bff3ae200dcc6b4809fed |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.