Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Card test in generated project #726

Merged
merged 2 commits into from
Jan 5, 2024
Merged

Fix Card test in generated project #726

merged 2 commits into from
Jan 5, 2024

Conversation

tiagoefmoraes
Copy link
Member

@tiagoefmoraes tiagoefmoraes commented Jan 4, 2024 •
edited
Loading

It's missing the Components submodule mix test in the generated project generates the warning:

warning: module SurfaceInitTestWeb.Card could not be loaded
Warning:   test/surface_init_test_web/components/card_test.exs:5: SurfaceInitTestWeb.Components.CardTest (module)

@tiagoefmoraes tiagoefmoraes self-assigned this Jan 4, 2024
@tiagoefmoraes tiagoefmoraes marked this pull request as ready for review January 4, 2024 17:47
@tiagoefmoraes tiagoefmoraes merged commit 81a9c57 into main Jan 5, 2024
5 checks passed
@tiagoefmoraes tiagoefmoraes deleted the fix_generated_card_test branch January 5, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msaraiva msaraiva msaraiva approved these changes

Assignees

@tiagoefmoraes tiagoefmoraes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tiagoefmoraes @msaraiva