SPT-1998 LoggerContext #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrandrewsmith
force-pushed
the
SPT-1998-logger
branch
from
6796f9c to
7876f6f
Compare
mrandrewsmith
force-pushed
the
SPT-1998-swift-concurrency
branch
from
ad7b710 to
14f1f97
Compare
mrandrewsmith
force-pushed
the
SPT-1998-logger
branch
2 times, most recently
from
504c200 to
e0f5b89
Compare
mrandrewsmith
force-pushed
the
SPT-1998-swift-concurrency
branch
from
546f421 to
66349e6
Compare
mrandrewsmith
force-pushed
the
SPT-1998-logger
branch
from
e0f5b89 to
41c91b8
Compare
NullIsOne
approved these changes
Mar 21, 2024
mrandrewsmith
force-pushed
the
SPT-1998-swift-concurrency
branch
from
15362f8 to
9fdb6e5
Compare
mrandrewsmith
force-pushed
the
SPT-1998-logger
branch
2 times, most recently
from
d552c4d to
b9f67bc
Compare
mrandrewsmith
force-pushed
the
SPT-1998-swift-concurrency
branch
from
90ce04e to
ea17d96
Compare
mrandrewsmith
force-pushed
the
SPT-1998-logger
branch
from
b9f67bc to
e1f2924
Compare
mrandrewsmith
force-pushed
the
SPT-1998-swift-concurrency
branch
from
ea17d96 to
23875fe
Compare
mrandrewsmith
force-pushed
the
SPT-1998-logger
branch
from
e1f2924 to
d6d531f
Compare
mrandrewsmith
force-pushed
the
SPT-1998-logger
branch
from
d6d531f to
6a5629e
Compare
Goldilocks97
requested changes
Apr 11, 2024
Goldilocks97
approved these changes
Apr 11, 2024
chausovSurfStudio
approved these changes
Apr 12, 2024
NodeKit.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is done
Так как для записи логов в async методах не используется Observer, который хранит логи, создал LoggingContext и перенес логику логов туда. В async методах нодов LoggingContext будет хранить логи с узлов, а LoggerNode разгребать его.