-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SPT-1998 Поддержка отмены таски для Combine #131
Closed
mrandrewsmith
wants to merge
9
commits into
SPT-1998-example-refresh
from
SPT-1998-combine-task-cancelation
Closed
SPT-1998 Поддержка отмены таски для Combine #131
mrandrewsmith
wants to merge
9
commits into
SPT-1998-example-refresh
from
SPT-1998-combine-task-cancelation
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrandrewsmith
requested review from
chausovSurfStudio,
NullIsOne and
Goldilocks97
April 17, 2024 15:16
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## SPT-1998-example-refresh #131 +/- ##
============================================================
- Coverage 91.39% 91.02% -0.37%
============================================================
Files 83 87 +4
Lines 1267 1304 +37
============================================================
+ Hits 1158 1187 +29
- Misses 109 117 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
NullIsOne
approved these changes
Apr 18, 2024
mrandrewsmith
force-pushed
the
SPT-1998-combine-task-cancelation
branch
2 times, most recently
from
May 2, 2024 15:54
be1212c
to
f3e65e3
Compare
mrandrewsmith
force-pushed
the
SPT-1998-example-refresh
branch
from
May 7, 2024 04:28
5804141
to
da998b5
Compare
mrandrewsmith
force-pushed
the
SPT-1998-combine-task-cancelation
branch
from
May 7, 2024 04:42
f3e65e3
to
f47756f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Что сделано
Примеры использования
Теперь для AsyncNode и AsyncStreamNode интерфейс один, но для каждого из них будет создан свой Publisher:
При отмене подписки будет вызван cancel у созданной таски:
При каждой новой подписке будет создана новая таска с вызовом метода process()
Шарить результат можно стандартными средствами Combine: