SPT 1998 Правки после попытки миграции (5) #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullIsOne
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## SPT-1998-fix-branch-build #135 +/- ##
=============================================================
+ Coverage 91.33% 91.41% +0.07%
=============================================================
Files 87 87
Lines 1351 1351
=============================================================
+ Hits 1234 1235 +1
+ Misses 117 116 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
NullIsOne
commented
May 7, 2024
There was a problem hiding this comment.
Эти старые тесты видимо потерялись просто при ребейзах.
Они исключены из pbxproj, но сами файлы остались и не компилировались.
Если открывать проект как package, то Xcode включал их в список тестов и пытался собрать. Безуспешно.
There was a problem hiding this comment.
Та же история.
У этого теста точно есть дублер, который Андрей уже написал на новом NodeKit
mrandrewsmith
force-pushed
the
SPT-1998-fix-branch-build
branch
from
6417752 to
04b4066
Compare
mrandrewsmith
changed the title
NullIsOne
force-pushed
the
SPT-1998-fix-migration-problems
branch
from
4b94036 to
09fdbc8
Compare
chausovSurfStudio
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Что сделано?
Решены небольшие проблемки, возникшие во время миграции модуля с сетевым слоем на новую версию.
AccessSafeNode.OutputкJsonURLCacheWriterNode