Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to exclude specific object from handling #70

Merged

Conversation

LastSprint
Copy link
Contributor

@LastSprint LastSprint commented Oct 26, 2021

#56 done!

Added AST tree shaking just after Yaml parsing. Seems works :D

Alexander Kravchenkov and others added 2 commits October 27, 2021 07:47
Co-authored-by: Margarita Volodina <volodina@surfstudio.ru>
Copy link
Contributor

@dmitryd20 dmitryd20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feature works fine, except for some cases

Sources/ASTTree/ASTNodeExcluder.swift Show resolved Hide resolved
.surfgen.generator.yaml Outdated Show resolved Hide resolved
Sources/Pipelines/CLI/Utils/Urls.swift Outdated Show resolved Hide resolved
@LastSprint LastSprint requested a review from dmitryd20 October 28, 2021 09:47
LastSprint and others added 2 commits October 28, 2021 12:57
Co-authored-by: Dmitry Demianov <dmitryd20@gmail.com>
@LastSprint LastSprint requested a review from dmitryd20 October 28, 2021 10:18
.surfgen.generator.yaml Outdated Show resolved Hide resolved
.surfgen.generator.yaml Outdated Show resolved Hide resolved
.surfgen.linter.yaml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Sources/Pipelines/CLI/CreateConfig/ConfigExample.swift Outdated Show resolved Hide resolved
Sources/Pipelines/CLI/CreateConfig/ConfigExample.swift Outdated Show resolved Hide resolved
Sources/Pipelines/CLI/CreateConfig/ConfigExample.swift Outdated Show resolved Hide resolved
@margarita-v
Copy link
Contributor

margarita-v commented Oct 29, 2021

надо бы выполнить одно из действий

  1. обновить бинарник в репо согласно новой логике
  2. автоматизировать обновление бинарника при мерже в репо
  3. удалить бинарник, чтобы пользователи сами выполняли make executable

в идеале сделать бы 2 опцию, мб отдельно, провайдить бинарник для мака и линукса

Alexander Kravchenkov and others added 6 commits November 1, 2021 10:42
Co-authored-by: Margarita Volodina <volodina@surfstudio.ru>
Co-authored-by: Margarita Volodina <volodina@surfstudio.ru>
Co-authored-by: Margarita Volodina <volodina@surfstudio.ru>
Co-authored-by: Margarita Volodina <volodina@surfstudio.ru>
Co-authored-by: Margarita Volodina <volodina@surfstudio.ru>
Co-authored-by: Margarita Volodina <volodina@surfstudio.ru>
@LastSprint
Copy link
Contributor Author

надо бы выполнить одно из действий

  1. обновить бинарник в репо согласно новой логике
  2. автоматизировать обновление бинарника при мерже в репо
  3. удалить бинарник, чтобы пользователи сами выполняли make executable

в идеале сделать бы 2 опцию, мб отдельно, провайдить бинарник для мака и линукса

Не в этом PR. Давай ишую

Alexander Kravchenkov and others added 2 commits November 1, 2021 10:45
Co-authored-by: Margarita Volodina <volodina@surfstudio.ru>
@LastSprint LastSprint merged commit c9a1af1 into master Nov 1, 2021
@LastSprint LastSprint deleted the possibility-to-exclude-specific-object-from-handling branch November 1, 2021 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants