Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SNP-400): Updates build badge route. #22

Merged
merged 3 commits into from
Apr 4, 2024
Merged

Conversation

ruinalsu
Copy link
Contributor

@ruinalsu ruinalsu commented Apr 20, 2023

Changes

Checklist for self-check

  • Commits and PRs have been filed according to the rules on the project.
  • The author is marked as an assigne and assigned mandatory reviewers.
  • Required labels marked
  • Specified related tasks and/or related PRs.
  • Specified Changes.
  • Attached videos/screenshots demonstrating the fix/feature.
  • All unspecified fields in the PR description deleted.
  • New code covered by tests.

Checklist for reviewers

  • CI passed successfully (with a green check mark).
  • PR is atomic, by volume no more than 400 (+-) corrected lines (not including codogen).

Design:

  • System design corresponds to the agreements on structure and architecture on the project.
  • The code is decomposed into necessary and sufficient components.

Functionality:

  • The code solves the problem.
  • Any changes to the user interface are reasonable and look good.

Complexity:

  • The code is clear, easy to read, functions are small, no more than 50 lines.
  • The logic is not overcomplicated, there is no overengineering (no code sections that may be needed in the future, but no one knows about it).

Tests:

  • Updated or added tests for mandatory components.
  • The tests are correct, helpful, and well designed/developed.

Naming:

  • The naming of variables, methods, classes and other components is understandable.

Comments:

  • The comments are understandable and helpful.

Documentation:

  • All labels are correct
  • Technical documentation updated (after approval, updates last reviewer).

@ruinalsu ruinalsu added the bug Something isn't working label Apr 20, 2023
@ruinalsu ruinalsu requested a review from dshevchenkoo April 20, 2023 13:32
@ruinalsu ruinalsu self-assigned this Apr 20, 2023
@danyaao danyaao assigned danyaao and unassigned ruinalsu Apr 3, 2024
@danyaao danyaao requested review from ekinsdrow and removed request for dshevchenkoo April 3, 2024 06:46
@danyaao danyaao closed this Apr 3, 2024
@danyaao danyaao reopened this Apr 3, 2024
@danyaao danyaao force-pushed the SNP-400_fix_build_badge branch from a79f663 to ff78b34 Compare April 3, 2024 07:02
Copy link

@ekinsdrow ekinsdrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Badge have failed status on this branch, is it ok?

image

Copy link

@ekinsdrow ekinsdrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(

@ekinsdrow ekinsdrow merged commit 152a8f1 into main Apr 4, 2024
6 checks passed
@ekinsdrow ekinsdrow deleted the SNP-400_fix_build_badge branch April 4, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working new pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants