Remove some == true / == false idioms (#155)

surge-synthesizer · Nov 25, 2024 · bf9bd09 · bf9bd09
1 parent eb3ae4c
commit bf9bd09
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 10 deletions.
diff --git a/include/sst/voice-effects/delay/StringResonator.h b/include/sst/voice-effects/delay/StringResonator.h
@@ -258,7 +258,7 @@ template <typename VFXConfig> struct StringResonator : core::VoiceEffectTemplate
 
         auto panParamOne = std::clamp((this->getFloatParam(fpPanOne) * .5f + .5f), 0.f, 1.f);
         auto panParamTwo = std::clamp((this->getFloatParam(fpPanTwo) * .5f + .5f), 0.f, 1.f);
-        if (this->getIntParam(ipStereo) == false)
+        if (!this->getIntParam(ipStereo))
         {
             panParamOne = 0.5f;
             panParamTwo = 0.5f;
@@ -370,7 +370,7 @@ template <typename VFXConfig> struct StringResonator : core::VoiceEffectTemplate
         levelLerpOne.set_target(levelParam);
 
         auto panParam = std::clamp((this->getFloatParam(fpPanOne) * .5f + .5f), 0.f, 1.f);
-        if (this->getIntParam(ipStereo) == false)
+        if (!this->getIntParam(ipStereo))
         {
             panParam = 0.5f;
         }
@@ -663,7 +663,7 @@ template <typename VFXConfig> struct StringResonator : core::VoiceEffectTemplate
     void processStereo(const float *const datainL, const float *const datainR, float *dataoutL,
                        float *dataoutR, float pitch)
     {
-        if (this->getIntParam(ipDualString == true))
+        if (this->getIntParam(ipDualString))
         {
             if (isShort)
             {
@@ -702,7 +702,7 @@ template <typename VFXConfig> struct StringResonator : core::VoiceEffectTemplate
 
     void processMonoToMono(const float *const datainL, float *dataoutL, float pitch)
     {
-        if (this->getIntParam(ipDualString == true))
+        if (this->getIntParam(ipDualString))
         {
             if (isShort)
             {

diff --git a/include/sst/voice-effects/distortion/BitCrusher.h b/include/sst/voice-effects/distortion/BitCrusher.h
@@ -151,7 +151,7 @@ template <typename VFXConfig> struct BitCrusher : core::VoiceEffectTemplateBase<
         }
         auto filterFreq = 440 * this->note_to_pitch_ignoring_tuning(cutoff);
 
-        if (priorFreq != filterFreq && filterSwitch == true)
+        if (priorFreq != filterFreq && filterSwitch)
         {
             filter.template setCoeffForBlock<VFXConfig::blockSize>(mode, filterFreq, reso,
                                                                    this->getSampleRateInv(), 0.f);
@@ -184,7 +184,7 @@ template <typename VFXConfig> struct BitCrusher : core::VoiceEffectTemplateBase<
             dataoutL[k] = level[0];
             dataoutR[k] = level[1];
         }
-        if (filterSwitch == true)
+        if (filterSwitch)
         {
             filter.processBlock<VFXConfig::blockSize>(dataoutL, dataoutR, dataoutL, dataoutR);
         }

diff --git a/include/sst/voice-effects/filter/CytomicSVF.h b/include/sst/voice-effects/filter/CytomicSVF.h
@@ -198,7 +198,7 @@ template <typename VFXConfig> struct CytomicSVF : core::VoiceEffectTemplateBase<
             auto mode = (sst::filters::CytomicSVF::Mode)(iparam[0]);
 
             auto res = std::clamp(param[2], 0.f, 1.f);
-            if (iparam[2] == true)
+            if (iparam[2])
             {
                 res *= .885f; // I just checked peak heights on a spectrum analyzer.
             }
@@ -245,7 +245,7 @@ template <typename VFXConfig> struct CytomicSVF : core::VoiceEffectTemplateBase<
     {
         calc_coeffs(pitch);
         cySvf[0].template processBlock<VFXConfig::blockSize>(datainL, datainR, dataoutL, dataoutR);
-        if (this->getIntParam(ipSlope) == true)
+        if (this->getIntParam(ipSlope))
         {
             cySvf[1].template processBlock<VFXConfig::blockSize>(dataoutL, dataoutR, dataoutL,
                                                                  dataoutR);

diff --git a/include/sst/voice-effects/modulation/Tremolo.h b/include/sst/voice-effects/modulation/Tremolo.h
@@ -454,7 +454,7 @@ template <typename VFXConfig> struct Tremolo : core::VoiceEffectTemplateBase<VFX
     void processStereo(const float *const datainL, const float *const datainR, float *dataoutL,
                        float *dataoutR, float pitch)
     {
-        if (this->getIntParam(ipHarmonic) == true)
+        if (this->getIntParam(ipHarmonic))
         {
             harmonicStereo(datainL, datainR, dataoutL, dataoutR, pitch);
         }
@@ -470,7 +470,7 @@ template <typename VFXConfig> struct Tremolo : core::VoiceEffectTemplateBase<VFX
     // ...this second one if incoming audio is Mono...
     void processMonoToMono(const float *const datainL, float *dataoutL, float pitch)
     {
-        if (this->getIntParam(ipHarmonic) == true)
+        if (this->getIntParam(ipHarmonic))
         {
             harmonicMono(datainL, dataoutL, pitch);
         }