-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix various typos #122
Fix various typos #122
Conversation
Found via `codespell -q 3 -L te`
install/mac/Stochas.pkgproj
Outdated
@@ -1608,14 +1608,14 @@ | |||
<dict> | |||
<key>BACKGROUND</key> | |||
<dict> | |||
<key>APPAREANCES</key> | |||
<key>APPEARANCES</key> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of these look good. However I am not sure we should change this pkgproj file as I doubt it was human edited, and I am not sure what the effect of changing this one file would be.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should i revert?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's for the Mac installer right? It did pass the test. Not familiar with Mac installers though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had the same thought - just that one file leave unchanged. I want to change the max installer to the one which signs that we use elsewhere soon enough. But for now having this commit be comments only would be best
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in ac0d148
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Will merge :)
Found via
codespell -q 3 -L te