Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various typos #122

Merged
merged 2 commits into from
Aug 29, 2022
Merged

Fix various typos #122

merged 2 commits into from
Aug 29, 2022

Conversation

luzpaz
Copy link
Contributor

@luzpaz luzpaz commented Aug 27, 2022

Found via codespell -q 3 -L te

Found via `codespell -q 3 -L te`
@@ -1608,14 +1608,14 @@
<dict>
<key>BACKGROUND</key>
<dict>
<key>APPAREANCES</key>
<key>APPEARANCES</key>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of these look good. However I am not sure we should change this pkgproj file as I doubt it was human edited, and I am not sure what the effect of changing this one file would be.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should i revert?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's for the Mac installer right? It did pass the test. Not familiar with Mac installers though

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had the same thought - just that one file leave unchanged. I want to change the max installer to the one which signs that we use elsewhere soon enough. But for now having this commit be comments only would be best

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in ac0d148

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Will merge :)

@baconpaul baconpaul merged commit 16f31fe into surge-synthesizer:main Aug 29, 2022
@luzpaz luzpaz deleted the typos branch August 29, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants