-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wavetable VCO - Non Fatal Label Glitch #856
Comments
well some condition is causing a redraw to not happen. Note that your waveform is also a bit off. I'm not sure what it is. I'll keep hunting while looking at the other tail-of-three-frame issue also. |
Ahh I see a missing invalidation which could cause this. Have a fix for both this and the corrupted tail paint on the pulse one shot which I should be able to get this morning. If that doesn't do it I am severely into 'no clue' land but it is consistent with what you show even though i don't see it here. (Missing repaints are always cpu and timing specific so can be platform dependent and stuff too) |
1. Fill frames for truncated tables with 0, fixing a problem with pulse wavetable in rack. Closes surge-synthesizer#843 2. Invalidate more completely when dirty since background is dirty dependent. Addresses surge-synthesizer#856 but will await for confirm to close
OK I pushed a change that I think will fix this - new nightly in about 30 minutes. If you could confirm. If it fixes I'll close this; if not i'll bump it to 2.2 because i have no other ideas right now and would like the ship the rest of the fixes :) |
OK, I placed the .vcvplugin file into ~/.Rack2/plugins/ folder and 'upgraded' Rack and restarted. The 'OneShot' label is 'fixed' now but the frame selection line when morphing seems borked just for the Pulse table. x-2023-03-06_09.05.15.mp4 |
Hmmm that version isn’t what I expected to see. Lemme give some more questions tomorrow But if the oneshot is fixed that’s great |
Great so I’ll close this and make a 2.1.4 this week |
And thanks! |
V.2.1.3.0
VCVRAck 2.2.2.
If you start VCV Rack that has a Wavetable VCO with a "OneShot" wavetable, its label is missing. But it returns if you change tables or zoom in/out.
The text was updated successfully, but these errors were encountered: