Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wavetable VCO - Non Fatal Label Glitch #856

Closed
therealkitman opened this issue Feb 23, 2023 · 10 comments
Closed

Wavetable VCO - Non Fatal Label Glitch #856

therealkitman opened this issue Feb 23, 2023 · 10 comments
Milestone

Comments

@therealkitman
Copy link

V.2.1.3.0
VCVRAck 2.2.2.

If you start VCV Rack that has a Wavetable VCO with a "OneShot" wavetable, its label is missing. But it returns if you change tables or zoom in/out.

image

@baconpaul baconpaul added this to the Xt 2.1.4 milestone Feb 23, 2023
@baconpaul
Copy link
Contributor

Having a hard time reproducing this.

Here's my network

Screen Shot 2023-03-04 at 10 11 43 AM

and when I load, I get a one shot and a correct draw of blip3

am I missing something in the report? Could you share your patch which shows this problem?

Thanks so much!

@therealkitman
Copy link
Author

Not much to show. I created a blank patch with the VCO as the only plugin. Usually happens if you're zoomed in on the plugin.

For what it's worth I'm using an Nvidia card and as I said it fixes itself after zooming in/out.

Chasing phantoms?

image

@baconpaul
Copy link
Contributor

well some condition is causing a redraw to not happen. Note that your waveform is also a bit off. I'm not sure what it is. I'll keep hunting while looking at the other tail-of-three-frame issue also.

@baconpaul
Copy link
Contributor

Ahh I see a missing invalidation which could cause this. Have a fix for both this and the corrupted tail paint on the pulse one shot which I should be able to get this morning.

If that doesn't do it I am severely into 'no clue' land but it is consistent with what you show even though i don't see it here. (Missing repaints are always cpu and timing specific so can be platform dependent and stuff too)

baconpaul added a commit to baconpaul/surge-rack that referenced this issue Mar 5, 2023
1. Fill frames for truncated tables with 0, fixing a problem
with pulse wavetable in rack. Closes surge-synthesizer#843

2. Invalidate more completely when dirty since background is
dirty dependent. Addresses surge-synthesizer#856 but will await for confirm to
close
baconpaul added a commit that referenced this issue Mar 5, 2023
1. Fill frames for truncated tables with 0, fixing a problem
with pulse wavetable in rack. Closes #843

2. Invalidate more completely when dirty since background is
dirty dependent. Addresses #856 but will await for confirm to
close
@baconpaul
Copy link
Contributor

OK I pushed a change that I think will fix this - new nightly in about 30 minutes. If you could confirm.

If it fixes I'll close this; if not i'll bump it to 2.2 because i have no other ideas right now and would like the ship the rest of the fixes :)

@therealkitman
Copy link
Author

therealkitman commented Mar 6, 2023

OK, I placed the .vcvplugin file into ~/.Rack2/plugins/ folder and 'upgraded' Rack and restarted. The 'OneShot' label is 'fixed' now but the frame selection line when morphing seems borked just for the Pulse table.

x-2023-03-06_09.05.15.mp4

@baconpaul
Copy link
Contributor

Hmmm that version isn’t what I expected to see. Lemme give some more questions tomorrow

But if the oneshot is fixed that’s great

@therealkitman
Copy link
Author

Maybe I should not have updated Surge? I did when I saw the red dot for the Library updates.

image

OK, I reinstalled the nightly, and re-ran testing. The "OneShot" label is still robust as well as the Pulse wavetable looking cleaner.

x-2023-03-06_11.13.51.mp4

@baconpaul
Copy link
Contributor

Great so I’ll close this and make a 2.1.4 this week

@baconpaul
Copy link
Contributor

And thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants