Fixed bailing out on empty lines and Add date applet.

[StefanSchroeder]

We were "return"ing on empty lines, but that's wrong. We want to skip empty lines and carry on with the next line.

[surma]

Although you are right that bailing on empty lines is indeed a bug, this is not the whole fix. Now the only way to exit the for-loop is by encountering an error, which in turn would make grep print an error message when encountering io.EOF. Could you add a if for that?

[StefanSchroeder]

Please wait. Fix pending.

2015-01-15 13:13 GMT+01:00 Alexander Surma notifications@github.com:

In applets/grep/grep.go
#8 (diff):

@@ -59,7 +59,7 @@ func doGrep(pattern *regexp.Regexp, fh io.Reader, fn string, print_fn bool) {
return
}
if line == "" {

•       break
  

•       continue
  

Although you are right that bailing on empty lines is indeed a bug, this
is not the whole fix. Now the only way to exit the for-loop is by
encountering an error, which in turn would make grep print an error message
when encountering io.EOF. Could you add a if for that?

—
Reply to this email directly or view it on GitHub
https://github.com/surma/gobox/pull/8/files#r23005769.

[StefanSchroeder]

I have also added a "date" applet and I am unable to branch off those commits so that they show up in a separate pull request. But the applet is pretty trivial, I think you can review it in 1 minute.

[surma]

I think you can review it in 1 minute.

I already did :D Consider it accepted.