Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasi-bindgen] Do not use serde-serialize #2

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

sgirones
Copy link
Member

wasi-bindgen's serde-serialize feature has been deprecated in favour of the serde-wasm-bindgen crate. See rustwasm/wasm-bindgen#3031 for more context, but in SurrealDB's case, it causes a dependency cycle when I try to add certain dependencies:

error: cyclic package dependency: package `getrandom v0.2.9` depends on itself. Cycle:
package `getrandom v0.2.9`

I checked all SurrealDB dependencies and they don't include the serde-serialize feature. Except for this one.

I was expecting cargo build or cargo test to fail, but they succeeded, so I assume the feature was not being used.

@tobiemh tobiemh merged commit c07677a into surrealdb:main Jun 13, 2023
@sgirones sgirones deleted the stop-using-serde-serialize branch July 3, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants