Explicit error when namespace and/or database are missing for HTTP engine #257
+7
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting this pull request! We appreciate you spending the time to work on these changes.
What is the motivation?
When no namespace and/or database is set a
ConnectionUnavailable
error will be thrown, this can be confusing as it does not clearly represent the problem.What does this change do?
It introduces a new
MissingNamespaceDatabase
error with a better description of what the problem is.What is your testing strategy?
N/A
Is this related to any issues?
fixes #245
Have you read the Contributing Guidelines?