Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not minify identifiers #298

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Do not minify identifiers #298

merged 1 commit into from
Jul 3, 2024

Conversation

kearfy
Copy link
Member

@kearfy kearfy commented Jul 3, 2024

Thank you for submitting this pull request! We appreciate you spending the time to work on these changes.

What is the motivation?

Minifying identifiers make them difficult to read in for example browsers when logging classes.

What does this change do?

Changes minification to only affect syntax and whitespace, excluding identifiers

What is your testing strategy?

GitHub CI

Is this related to any issues?

No

Have you read the Contributing Guidelines?

@kearfy kearfy merged commit e5ec128 into surrealdb:main Jul 3, 2024
8 checks passed
@kearfy kearfy deleted the micha/dont-minify-identifiers branch July 3, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant