Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose engines type #349

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Expose engines type #349

merged 1 commit into from
Oct 1, 2024

Conversation

macjuul
Copy link
Contributor

@macjuul macjuul commented Oct 1, 2024

Thank you for submitting this pull request! We appreciate you spending the time to work on these changes.

What is the motivation?

Improved typing in WASM and Node SDKs

What does this change do?

Exposes the Engines type, which we consider to be the recommended way to register additional engines

What is your testing strategy?

N/A

Is this related to any issues?

If this pull request is related to any other pull request or issue, or resolves any issues - then link all related pull requests and issues here.

Have you read the Contributing Guidelines?

@macjuul macjuul requested a review from kearfy as a code owner October 1, 2024 09:47
@kearfy kearfy merged commit 5cf668d into main Oct 1, 2024
10 checks passed
@kearfy kearfy deleted the change/expose-engines branch October 1, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants