README switch-case example does not work with webpack env object

[cmavelis]

Using switch(env) when env is an object and the cases are strings will always go to the default. It seems either the example is out of date or it should just be an if block.

module.exports = env => {
  switch(env) {
    case 'development':
      return merge(commonConfig, developmentConfig);
    case 'production':
      return merge(commonConfig, productionConfig);
    default:
      throw new Error('No matching configuration was found!');
  }
}

[cmavelis]

This is what I used instead:

module.exports = env => {
    if (env['development']) {
        return merge(commonConfig, devConfig);
    } else if (env['production']) {
        return merge(commonConfig, prodConfig);
    } else {
        throw new Error('Please specify webpack "--env development" or "--env production"');
    }
};

[bebraw]

webpack 5 had a breaking change here but I forgot to update the readme. Thanks for the heads up.

…

On 19.03.2021, at 15:39, Cameron Avelis ***@***.***> wrote:  Using switch(env) when env is an object and the cases are strings will always go to the default. It seems either the example is out of date or it should just be an if block. module.exports = env => { switch(env) { case 'development': return merge(commonConfig, developmentConfig); case 'production': return merge(commonConfig, productionConfig); default: throw new Error('No matching configuration was found!'); } } — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[bebraw]

This was solved in #180.