Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update example code of Limitations #180

Merged
merged 1 commit into from
Jun 7, 2021

Conversation

Gavin-Gong
Copy link
Contributor

just adjust example code by webpack doc

for previous code
if you use webpack --env development command in webpack 5.3,
then env will be
{ WEBPACK_SERVE: true, development: true }, instead of development or production

@codecov-io
Copy link

codecov-io commented Apr 8, 2021

Codecov Report

Merging #180 (1bb6dab) into develop (28cfdbd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #180   +/-   ##
========================================
  Coverage    99.14%   99.14%           
========================================
  Files            6        6           
  Lines          233      233           
  Branches        64       64           
========================================
  Hits           231      231           
  Misses           2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28cfdbd...1bb6dab. Read the comment docs.

@bebraw bebraw merged commit afe5581 into survivejs:develop Jun 7, 2021
@bebraw
Copy link
Member

bebraw commented Jun 7, 2021

Thanks! Sorry for the late merge (busy with other things).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants