fix unicode decode error #125
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sushant10
requested changes
Jun 14, 2018
sushant10
requested changes
Jun 14, 2018
|
Windows 10 was tested working by this guy. I can't test a Mac; I don't have one. But I see no reason why not, nothing OS specific was changed. The space changes are my editor removing trailing whitespace in accordance with good coding style. Do you want me to revert that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #90
Since python opens files in whatever the default character encoding for a given system is, computers that do not use UTF8 by default will raise a unicode error when reading fancy quotes. This PR both removes unicode characters from the data files and specifies the encoding to use.