add logs for debugging

sushantmane · Aug 4, 2023 · 82f445a · 82f445a
1 parent 9fe04b7
commit 82f445a
Show file tree

Hide file tree

Showing 5 changed files with 65 additions and 32 deletions.
diff --git a/...ent/src/main/java/com/linkedin/davinci/notifier/MetaSystemStoreReplicaStatusNotifier.java b/...ent/src/main/java/com/linkedin/davinci/notifier/MetaSystemStoreReplicaStatusNotifier.java
@@ -36,8 +36,9 @@ public MetaSystemStoreReplicaStatusNotifier(
   void report(String kafkaTopic, int partitionId, ExecutionStatus status) {
     String storeName = Version.parseStoreFromKafkaTopicName(kafkaTopic);
     VeniceSystemStoreType systemStoreType = VeniceSystemStoreType.getSystemStoreType(storeName);
-    if (systemStoreType != null && systemStoreType.equals(VeniceSystemStoreType.META_STORE)) {
-      // No replica status reporting for meta system stores
+    if (systemStoreType != null && (systemStoreType.equals(VeniceSystemStoreType.META_STORE)
+        || systemStoreType.equals(VeniceSystemStoreType.DAVINCI_PUSH_STATUS_STORE))) {
+      // No replica status reporting for system stores
       return;
     }
     Store store;

diff --git a/...src/main/java/com/linkedin/venice/pubsub/adapter/kafka/admin/ApacheKafkaAdminAdapter.java b/...src/main/java/com/linkedin/venice/pubsub/adapter/kafka/admin/ApacheKafkaAdminAdapter.java
@@ -158,20 +158,6 @@ public void createTopic(
     }
   }
 
-  @Override
-  public Set<PubSubTopic> listAllTopics() {
-    ListTopicsResult listTopicsResult = getKafkaAdminClient().listTopics();
-    try {
-      return listTopicsResult.names()
-          .get()
-          .stream()
-          .map(t -> pubSubTopicRepository.getTopic(t))
-          .collect(Collectors.toSet());
-    } catch (Exception e) {
-      throw new PubSubClientException("Failed to list all topics due to exception: ", e);
-    }
-  }
-
   @Override
   public void deleteTopic(PubSubTopic topic, Duration timeout) {
     try {
@@ -200,6 +186,20 @@ public void deleteTopic(PubSubTopic topic, Duration timeout) {
     }
   }
 
+  @Override
+  public Set<PubSubTopic> listAllTopics() {
+    ListTopicsResult listTopicsResult = getKafkaAdminClient().listTopics();
+    try {
+      return listTopicsResult.names()
+          .get()
+          .stream()
+          .map(t -> pubSubTopicRepository.getTopic(t))
+          .collect(Collectors.toSet());
+    } catch (Exception e) {
+      throw new PubSubClientException("Failed to list all topics due to exception: ", e);
+    }
+  }
+
   @Override
   public void setTopicConfig(PubSubTopic topic, PubSubTopicConfiguration pubSubTopicConfiguration)
       throws PubSubTopicDoesNotExistException {

diff --git a/...grationTest/java/com/linkedin/venice/integration/utils/VeniceClusterWrapperConstants.java b/...grationTest/java/com/linkedin/venice/integration/utils/VeniceClusterWrapperConstants.java
@@ -26,5 +26,5 @@ public class VeniceClusterWrapperConstants {
   public static final String CHILD_REGION_NAME_PREFIX = "dc-";
 
   // constant for tests with just one data center/region
-  public static final String STANDALONE_REGION_NAME = "planet-earth";
+  public static final String STANDALONE_REGION_NAME = "testRegion";
 }
diff --git a/internal/venice-test-common/src/integrationTest/resources/log4j.properties b/internal/venice-test-common/src/integrationTest/resources/log4j.properties
diff --git a/internal/venice-test-common/src/integrationTest/resources/log4j2.properties b/internal/venice-test-common/src/integrationTest/resources/log4j2.properties
@@ -6,17 +6,58 @@ filters = threshold
 filter.threshold.type = ThresholdFilter
 filter.threshold.level = debug
 
-appenders = console
+log4j2.isThreadContextMapInheritable=true
+
+#appenders = console
+# Uncomment the following line to enable file logging
+appenders = rolling
 
 appender.console.type = Console
 appender.console.name = STDOUT
 appender.console.layout.type = PatternLayout
-appender.console.layout.pattern = %d{yyyy-MM-dd HH:mm:ss} - [%X{component}] %p [%c{1}] [%t] %m%n
+appender.console.layout.pattern = %d{yyyy-MM-dd HH:mm:ss} [%X{component}] %p [%c{1}] [%t] %m%n
+
+appender.rolling.type = RollingFile
+appender.rolling.name = fileLogger
+appender.rolling.fileName = ${sys:user.dir}/build/logs/vxc-e2e-test.log
+appender.rolling.filePattern = ${sys:user.dir}/build/logs/app_%d{yyyyMMdd}.log.gz
+appender.rolling.layout.type = PatternLayout
+appender.rolling.layout.pattern = %d{yyyy-MM-dd HH:mm:ss} %p [%c{1.}:%L] [%t] [%tid] %m%n
+appender.rolling.policies.type = Policies
 
 rootLogger.level = info
-rootLogger.appenderRefs = stdout
-rootLogger.appenderRef.stdout.ref = STDOUT
+rootLogger.appenderRefs = console, rolling
+rootLogger.appenderRef.console.ref = STDOUT
+rootLogger.appenderRef.rolling.ref = fileLogger
 
-# Set package org.apache.zookeeper log level to error.
 logger.zk.name = org.apache.zookeeper
-logger.zk.level = error
+logger.zk.level = error
+
+# Uncomment the following lines to and change the level to debug to enable debug logging
+
+#logger.mario.name = com.linkedin.mario
+#logger.mario.level = off
+
+#logger.xinfra.name = com.linkedin.xinfra
+#logger.xinfra.level = off
+
+logger.apache.name = org.apache
+logger.apache.level = error
+
+logger.kafka.name = kafka
+logger.kafka.level = error
+
+logger.e.name = org.eclipse
+logger.e.level = off
+
+logger.d2.name = com.linkedin.d2
+logger.d2.level = error
+
+logger.venice-xc.name = com.linkedin.venice.pubsub.adapter.xinfra
+logger.venice-xc.level = debug
+
+logger.vs.name = com.linkedin.venice.serialization.avro
+logger.vs.level = off
+
+logger.vu.name = com.linkedin.venice.utils
+logger.vu.level = off