Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Router #810

Closed
wants to merge 0 commits into from
Closed

Update Router #810

wants to merge 0 commits into from

Conversation

Dusknight4
Copy link
Contributor

@Dusknight4 Dusknight4 commented May 18, 2023

Updated router to include XSushi and Sushi as base pairs on Optimism, Fantom, and Polygon.

Updated router to include XSushi as a base pair on Ethereum.

Updated router to include custom routing for Two-Link.

Updated router to include Weth9 as a base pair on Optimism.


PR-Codex overview

Focus of the PR:

This PR focuses on adding new tokens and bases for trading on different chains.

Detailed summary:

  • Added WETH9 token for trading on the OPTIMISM chain.
  • Added ThreeCoin token for trading on the POLYGON chain.
  • Added FourCoin token for trading on the FANTOM chain.
  • Added OP token for trading on the OPTIMISM chain.
  • Added LINK token for trading on the ETHEREUM chain.
  • Added multiple tokens (GNS, SAND, STG, UNI, SUSHI, RNDR, TEL, GRT, BAL, QUICK, OCEAN) for trading on the POLYGON chain.
  • Added XSUSHI token for trading on the POLYGON chain.
  • Added SUSHI token for trading on the FANTOM chain.
  • Added LINK token for trading on the OPTIMISM chain.
  • Added multiple tokens (WNATIVE, WETH9, SNX, WBTC, LINK, SUSHI, XSUSHI) for trading on the OPTIMISM chain.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented May 18, 2023

⚠️ No Changeset found

Latest commit: 5259d59

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented May 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
analytics ❌ Failed (Inspect) Jul 29, 2023 3:30pm
balances ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2023 3:30pm
earn ❌ Failed (Inspect) Jul 29, 2023 3:30pm

@vercel
Copy link

vercel bot commented May 18, 2023

@Dusknight4 is attempting to deploy a commit to the Sushi Team on Vercel.

A member of the Team first needs to authorize it.

@matthewlilley
Copy link
Collaborator

matthewlilley commented May 22, 2023

Okay, so I should probably explain the trade-offs of different routing configurations.

Bases to check trades against - this list should be minimal with only bases which are extremely common. WETH/WBTC/STABLECOINS etc... for example, adding SUSHI & XSUSHI here probably doesn't make sense because there are so few pools with liquidity paired up with SUSH & XSUSHI, and for every base added in this config, swaps become slower because more pools need to be checked for existence.

Additional bases & custom bases allow for more fine-tuned config which will not cause the same slow down.

There is a little more involved with configuring the routing config too, tokens & addresses need adding in packages/currency/constants/(tokens|token-addresses) as well and imported into the router config. If you opened up with vscode you'll see the issues I'm talking about with imports missing.

@Dusknight4
Copy link
Contributor Author

Dusknight4 commented May 23, 2023

Thank you for the explanation!

I have removed Sushi and XSushi as "bases to check trades against", except for on Polygon where there is 30k of Sushi/XSushi liquidity, the latter of which is unroutable. In its current state users are unable to access any of the 10,000+ xSushi on polygon unless you manually input Sushi as the trading pair. I posted a message about it in discord. I'm sure many users will enjoy accessing Sushi's core token on the Polygon network without having to manually input a certain pair.

I'm looking to fix routing for the XSushi-Three pool I created in celebration of Sushiswap supporting my custom routing, and add support for a potential Sushi-Three and Avax-Three pool as well.

Due to my tokens being paired with a diverse array of liquidity, it made sense to add them into "bases to check trades against" in order to reduce the amount of fragmented liquidity. However if it would reduce lag then it might be better to add custom pairs for Three and FourCoin's token pair counterparts individually.

I thank you again for your help and I'm really grateful for your time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants