-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Router #810
Update Router #810
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@Dusknight4 is attempting to deploy a commit to the Sushi Team on Vercel. A member of the Team first needs to authorize it. |
Okay, so I should probably explain the trade-offs of different routing configurations. Bases to check trades against - this list should be minimal with only bases which are extremely common. WETH/WBTC/STABLECOINS etc... for example, adding SUSHI & XSUSHI here probably doesn't make sense because there are so few pools with liquidity paired up with SUSH & XSUSHI, and for every base added in this config, swaps become slower because more pools need to be checked for existence. Additional bases & custom bases allow for more fine-tuned config which will not cause the same slow down. There is a little more involved with configuring the routing config too, tokens & addresses need adding in packages/currency/constants/(tokens|token-addresses) as well and imported into the router config. If you opened up with vscode you'll see the issues I'm talking about with imports missing. |
Thank you for the explanation! I have removed Sushi and XSushi as "bases to check trades against", except for on Polygon where there is 30k of Sushi/XSushi liquidity, the latter of which is unroutable. In its current state users are unable to access any of the 10,000+ xSushi on polygon unless you manually input Sushi as the trading pair. I posted a message about it in discord. I'm sure many users will enjoy accessing Sushi's core token on the Polygon network without having to manually input a certain pair. I'm looking to fix routing for the XSushi-Three pool I created in celebration of Sushiswap supporting my custom routing, and add support for a potential Sushi-Three and Avax-Three pool as well. Due to my tokens being paired with a diverse array of liquidity, it made sense to add them into "bases to check trades against" in order to reduce the amount of fragmented liquidity. However if it would reduce lag then it might be better to add custom pairs for Three and FourCoin's token pair counterparts individually. I thank you again for your help and I'm really grateful for your time. |
Updated router to include XSushi and Sushi as base pairs on Optimism, Fantom, and Polygon.
Updated router to include XSushi as a base pair on Ethereum.
Updated router to include custom routing for Two-Link.
Updated router to include Weth9 as a base pair on Optimism.
PR-Codex overview
Focus of the PR:
This PR focuses on adding new tokens and bases for trading on different chains.
Detailed summary:
WETH9
token for trading on theOPTIMISM
chain.ThreeCoin
token for trading on thePOLYGON
chain.FourCoin
token for trading on theFANTOM
chain.OP
token for trading on theOPTIMISM
chain.LINK
token for trading on theETHEREUM
chain.GNS
,SAND
,STG
,UNI
,SUSHI
,RNDR
,TEL
,GRT
,BAL
,QUICK
,OCEAN
) for trading on thePOLYGON
chain.XSUSHI
token for trading on thePOLYGON
chain.SUSHI
token for trading on theFANTOM
chain.LINK
token for trading on theOPTIMISM
chain.WNATIVE
,WETH9
,SNX
,WBTC
,LINK
,SUSHI
,XSUSHI
) for trading on theOPTIMISM
chain.