Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apps/swap): use fiat value from tines in CurrencyInput #948

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

0xMasayoshi
Copy link
Contributor

@0xMasayoshi 0xMasayoshi commented Jun 21, 2023

PR-Codex overview

This PR adds a new hook useUSDCPrice and updates some existing hooks and components to use it. It calculates the price of a given token in USDC based on the available liquidity pools.

Detailed summary

  • Adds a new hook useUSDCPrice to calculate the price of a given token in USDC based on available liquidity pools
  • Updates usePctChange and PricePanel to use useUSDCPrice
  • Updates CurrencyInput to import useUSDCPrice instead of usePrice
  • Updates Trade and SwapCurrencyOutput to use usdPctChange from PricePanel
  • Adds a new file usePoolsCodeMap to fetch the available liquidity pools for a given token pair

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Jun 21, 2023

EGN-394 Fiat price impact is often wrong because it's using stale fiat prices

It should use current fiat prices based on the AMM instead of the price API which can be stale up to 30m.

image.png

@changeset-bot
Copy link

changeset-bot bot commented Jun 21, 2023

⚠️ No Changeset found

Latest commit: add5831

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jun 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
academy ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 26, 2023 3:06pm
analytics ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 26, 2023 3:06pm
balances ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 26, 2023 3:06pm
blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 26, 2023 3:06pm
earn ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 26, 2023 3:06pm
furo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 26, 2023 3:06pm
pools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 26, 2023 3:06pm
root ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 26, 2023 3:06pm
token-list ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 26, 2023 3:06pm
token-price ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 26, 2023 3:06pm
tokens ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 26, 2023 3:06pm

@0xMasayoshi 0xMasayoshi marked this pull request as draft June 21, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants