Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apps/earn): fix query not loaded yet #967

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Conversation

LufyCZ
Copy link
Collaborator

@LufyCZ LufyCZ commented Jun 25, 2023

PR-Codex overview

This PR adds a query parameter validation to the PositionPage component in apps/earn/pages/position/[tokenId]/index.tsx.

Detailed summary

  • Added query parameter validation using queryParamsSchema.safeParse.
  • If validation fails, the component will return an empty fragment.
  • No other notable changes were made.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Jun 25, 2023

⚠️ No Changeset found

Latest commit: 4b7ff81

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jun 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
academy ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2023 3:06pm
analytics ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2023 3:06pm
balances ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2023 3:06pm
blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2023 3:06pm
earn ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2023 3:06pm
furo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2023 3:06pm
pools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2023 3:06pm
root ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2023 3:06pm
token-list ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2023 3:06pm
token-price ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2023 3:06pm
tokens ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2023 3:06pm

@LufyCZ
Copy link
Collaborator Author

LufyCZ commented Jun 25, 2023

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants