Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENTMOOT strategy #77

Merged
merged 9 commits into from
Nov 24, 2020
Merged

Conversation

jezsadler
Copy link
Contributor

Initialization and suggest_experiments functionality is implemented.

First take on ENTMOOT strategy - init and suggest_experiments functions implemented.
Fixed some of the documentation
@marcosfelt
Copy link
Collaborator

Let me know if you are able to add tests. Looks good so far

@marcosfelt
Copy link
Collaborator

marcosfelt commented Nov 14, 2020

Hy @jezsadler, last couple things. Are there any dependencies for ENTMOOT? You can add them via poetry or if you tell me, I can do that.

Also, I just noticed that the tests aren't running. Could you replace the second line of .github/wokflow/ci.yml with this:

 push:
  pull_request:
    branches:
      # Branches from forks have the form 'user:branch-name' so we only run
      # this job on pull_request events for branches that look like fork
      # branches. Without this we would end up running this job twice for non
      # forked PRs, once for the push and then once for opening the PR.
    - '**:**'

@marcosfelt marcosfelt merged commit 44c25aa into sustainable-processes:master Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants