Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark across Parse options, add memory benchmarking. #264

Merged
merged 2 commits into from
Feb 26, 2023

Conversation

suyashkumar
Copy link
Owner

@suyashkumar suyashkumar commented Feb 26, 2023

This change updates the Parse benchmark to operate across useful ParseOptions, adds memory benchmarking, and updates some benchmark params.

For example, we can take a look at the CPU / memory differences across the new ParseOptions for one of the test dicoms:

BenchmarkParse/NoOptions/4.dcm-4                                     	      10	 106876945 ns/op	120572543 B/op	    2160 allocs/op
BenchmarkParse/SkipPixelData/4.dcm-4                                 	      10	    531193 ns/op	   34900 B/op	    2144 allocs/op
BenchmarkParse/SkipProcessingPixelDataValue/4.dcm-4                  	      10	   1807256 ns/op	 7573518 B/op	    2146 allocs/op

@suyashkumar suyashkumar marked this pull request as ready for review February 26, 2023 04:51
@suyashkumar suyashkumar changed the title Update Parse benchmark to operate across useful ParseOptions, add memory benchmarking, update benchmark params. Benchmark across Parse options, add memory benchmarking. Feb 26, 2023
@suyashkumar suyashkumar self-assigned this Feb 26, 2023
@suyashkumar suyashkumar merged commit 75975a5 into main Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant