Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Application Entity (AE) value parsing #276

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

bench
Copy link
Contributor

@bench bench commented Jun 6, 2023

fix #275

Values with VRs constructed of character strings, except in the case of the VR UI, shall be padded with SPACE characters (20H, in the Default Character Repertoire) when necessary to achieve even length.

AE is no exception.

TYVM @suyashkumar :)

Signed-off-by: Benjamin Chenebault <benjamin.chenebault@health-data-hub.fr>
Copy link
Owner

@suyashkumar suyashkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution and for the detailed issue report!

@suyashkumar suyashkumar merged commit 5894fa3 into suyashkumar:main Jun 9, 2023
@bench
Copy link
Contributor Author

bench commented Sep 28, 2023

hi @suyashkumar !
Will you plan a release soon ?

@suyashkumar
Copy link
Owner

suyashkumar commented Sep 30, 2023

@bench sure, done! https://github.com/suyashkumar/dicom/releases/tag/v1.0.7

Thanks for the nudge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Value representation "Application Entity" is not correclly serialized
2 participants