Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

write: pad certain VRs with spaces instead of null bytes #81

Merged
merged 1 commit into from
May 30, 2020
Merged

write: pad certain VRs with spaces instead of null bytes #81

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion write/writer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,14 @@ func Element(e *dicomio.Encoder, elem *element.Element, opts ...Option) {
}
sube.WriteString(s)
if len(s)%2 == 1 {
sube.WriteByte(0)
switch vr {
// Values with VRs constructed of character strings, except in the case of the VR UI, shall be padded with SPACE characters
// per http://dicom.nema.org/medical/dicom/current/output/html/part05.html#sect_6.2
case "DT", "LO", "LT", "PN", "SH", "ST", "UT":
sube.WriteString(" ")
default:
sube.WriteByte(0)
}
}
}
if sube.Error() != nil {
Expand Down