Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use all flash #75

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Use all flash #75

merged 1 commit into from
Oct 4, 2024

Conversation

ilc
Copy link
Collaborator

@ilc ilc commented Oct 1, 2024

Previously we'd only been using 8k of the available flash
for our storage of vial elements. That has been increased
to 64k.

We'd also previously only been using 2mb of the 16mb of flash
we have. While not that useful right now, it should be later.

Copy link
Collaborator

@SiriusStarr SiriusStarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the achordion changes are up in #74 can we lose them from this PR? Or are we just going to cherrypick 5e06b57?

Previously we'd only been using 8k of the available flash
for our storage of vial elements.  That has been increased
to 64k.

We'd also previously only been using 2mb of the 16mb of flash
we have.  While not that useful right now, it should be later.
@SiriusStarr SiriusStarr self-requested a review October 3, 2024 20:14
Copy link
Collaborator

@SiriusStarr SiriusStarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Running on it here with no issues.

@ilc ilc merged commit 63be294 into svalboard:vial Oct 4, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants