-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BUILD_EXE as cmake option #717
Conversation
cmake/DAGMC_macros.cmake
Outdated
endmacro () | ||
|
||
# Install a unit test | ||
macro (dagmc_install_test test_name ext) | ||
message(STATUS "Building unit tests: ${test_name}") | ||
if (NOT BUILD_EXEC) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be BUILD_EXE
not BUILD_EXEC
I am now missing the includes :( in the install folder.... |
I think that's a problem in the
while the static library section starts like this:
The static library section doesn't set the public headers as part of the target properties. |
included the static header install fix in this PR.... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few small items from me here.
cmake/DAGMC_macros.cmake
Outdated
@@ -66,6 +66,7 @@ macro (dagmc_setup_options) | |||
option(BUILD_SHARED_LIBS "Build shared libraries" ON) | |||
option(BUILD_STATIC_LIBS "Build static libraries" ON) | |||
|
|||
option(BUILD_EXE "Build DAGMC executables" ON) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's indent the comment string to match the other options.
Co-authored-by: Patrick Shriwise <pshriwise@gmail.com>
@pshriwise is there some still some undressed comments in here ? |
@bam241 can you remind me what the use case is for building without executables? |
The plugin. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All my comments were addressed. Looks good @bam241!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks @bam241
This should allow to build dagmc libs (shared and.or static) without the exe.