Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding CMake Version File #722

Merged
merged 3 commits into from
Jan 21, 2021
Merged

Conversation

pshriwise
Copy link
Member

Description

Addressing #721 here. This is fairly simple -- just adds a version file to simplify any external version checking from other packages.

@pshriwise pshriwise requested a review from ljacobson64 January 18, 2021 17:15
@ljacobson64
Copy link
Member

ljacobson64 commented Jan 18, 2021

Just tested this with find_package(DAGMC REQUIRED VERSION 3.3.0) and cmake did not give an error

@pshriwise
Copy link
Member Author

pshriwise commented Jan 18, 2021

According to the find_package docs, it would be

find_package(DAGMC 3.3.0 REQUIRED)

to ensure a specific version is found.

I tried the same as you expecting some kind of warning from CMake about the VERSION, but I didn't see anything. Maybe that generally has some other purpose in CMake functions?

@ljacobson64
Copy link
Member

Ah, so my syntax was wrong. I tested it with the right syntax and it behaves appropriately now.

@pshriwise
Copy link
Member Author

Are we happy with these changes as they are?

@ljacobson64 ljacobson64 merged commit 0fa764a into svalinn:develop Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants