Windows #727
Merged
Windows #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try semicolons.
|
How did this break? 😢 Was it moving the gtest into a separate PR? |
|
No basically I can get the right way to had the test into the PATH
B. Mouginot
… On Aug 5, 2021, at 15:17, Paul Wilson ***@***.***> wrote:
How did this break? 😢
Was it moving the gtest into a separate PR?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
This latest update didn't seem to launch actions from your |
|
Huh - I think it's because you don't launch on push for this workflow. |
|
@gonuke I fixed it ! |
gonuke
requested changes
Aug 21, 2021
Co-authored-by: Paul Wilson <paul.wilson@wisc.edu>
|
One last cleanup request.... rename the tasks in a consistent way:
|
Co-authored-by: Paul Wilson <paul.wilson@wisc.edu>
|
I'm not sure whether or not this needs a rebase? |
|
I don't think so, there is no conflict. |
|
This is such a great step forward! Thanks for tracking this all down @bam241 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow to build dagmc on windows.
Still a draft as this needs a new version of PyNE. (right now pulling the one from my fork.)