moved to sequential docker building #748
Conversation
|
Perhaps add the badge to the README as part of this PR, as well? Why is this failing on circleci? |
|
I've added the badge to the readme and removed the unnecessary housekeeping build with Ubuntu 18.04 |
|
Can you rebase this? it should allow it to pass the CircleCI builds as well |
|
I manually restarted the CI to make sure we have correctly identified (and fix) the issue with CI here. |
|
still failing on circle because it doesn't have the right Pyhton 3 stuff maybe? |
|
that's why it may need the rebase? |
|
I'm a little confused that the changes from #747 are showing up as changes here.... it probably doesn't matter... |
gonuke
force-pushed
the
sequential_docker_builds
branch
from
045f282 to
906afc4
Compare
|
I rebased again to cleanup the history |
|
Will merge after tests pass - they should since the code is identical to the last set of tests! |
|
looking good merging. (so we see if we can still push imp to svalinn registry) |
Description
This is a minor change to the docker CI image building process. It uses "needs" keyword in the steps for docker images building to ensure the images are getting the most up to date version of the previous image.
This has a nice upgrade path as I think it is compatible with docker layer caching which would speed up the overall process.
Also if we like a badge can be added to the README ?
Motivation and Context
Ensures images build on the latest previous base images
Cleaner presentation of build process with connections between images identified on the GH actions
Changes
What kind of change does this PR introduce? (Bug fix, feature, documentation update...)
update to current GH action building the dockerfiles
Behavior
What is the current behavior? What is the new behavior?
Current behavior is one large matrix of builds, new process is sequential matrixes of builds with "needs" keyword
News file
done