integration of test for dockerfile update #754

bam241 · 2021-07-12T16:00:23Z

duplicating test for docker file update.

bam241 · 2021-07-12T16:04:18Z

also added a contiditon push based on PR status

bam241 · 2021-07-12T16:04:52Z

@shimwell do you know if my implementation will use cashed img ?

shimwell · 2021-07-12T16:43:23Z

@shimwell do you know if my implementation will use cashed img ?

I can see 12 jobs all running in parallel as the first stage. I don't think these will make use of cached images.

Perhaps the needs argument can be used in a few places to make sure the base images have been built first

I think the test_docker section will make use of previously build cached images that were build in the first section, but it should all appear in the logs

gonuke · 2021-07-12T18:54:32Z

.github/workflows/docker_publish.yml

          build-args: |
            UBUNTU_VERSION=${{ matrix.ubuntu_versions }}
-          tags: ghcr.io/svalinn/dagmc-ci-ubuntu-${{ matrix.ubuntu_versions }}
+          tags: ghcr.io/svalinn/test_dagmc-ci-ubuntu-${{ matrix.ubuntu_versions }}


This will need to include some other unique string (sha?) to avoid two simultaneous PR's from overwriting each other

gonuke · 2021-07-12T19:29:59Z

.github/workflows/docker_publish.yml

+
+      - name: Environment setup
+        run: |
+          if [ "${{ matrix.isMerged }}" == "true" ]; then


Maybe I don't understand how the isMerged works, but this seems like the logic is reversed. Don't we want the sha for PRs and without a sha for merged?

gonuke

Oops

gonuke · 2021-07-14T19:22:45Z

CI/Dockerfile_1_external_deps

-ARG UBUNTU_VERSION=18.04
-FROM ghcr.io/svalinn/dagmc-ci-ubuntu-${UBUNTU_VERSION}
+ARG UBUNTU_VERSION=18.04ARG
+ROOT_NAME=dagmc


Suggested change

ROOT_NAME=dagmc

ARG ROOT_NAME=dagmc

bam241 · 2021-07-15T15:34:33Z

closing and reopening from upstream

… working well..

gonuke

This should fix the most recent error

CI/Dockerfile_3_moab

Co-authored-by: Paul Wilson <paul.wilson@wisc.edu>

bam241 · 2021-07-17T17:28:28Z

@gonuke thx for the suggestion ! it seems tone working now !

One need to make sure the retagging is working well, then I disable retag on personal branch and this should be good to go.

bam241 · 2021-07-17T17:29:12Z

not that I rearranged @shimwell slicing to avoid uploading image we don't use or don't need to exchange between jobs...

gonuke

Another typo?

.github/workflows/docker_publish.yml

Co-authored-by: Paul Wilson <paul.wilson@wisc.edu>

gonuke · 2021-07-18T20:50:06Z

If we hard-coded the matrix, could we get more parallelism on the expensive builds?

bam241 · 2021-07-18T21:26:56Z

@gonuke I am happy with his.

package are tagged as stable when test pass (set on merge) https://github.com/bam241/DAGMC/pkgs/container/dagmc-ci-ubuntu-18.04-gcc-ext-hdf5_1.10.4-moab_develop

I also limited the retagging to svalinn only to limit the amount of pollution we are producing in users forks....

bam241 · 2021-07-18T21:28:32Z

If we hard-coded the matrix, could we get more parallelism on the expensive builds?

we already have parallelism for the 4 expensive builds

bam241 · 2021-07-18T21:30:30Z

see https://github.com/bam241/DAGMC/actions/runs/1042760146
the Matrix: build-deps-img box

gonuke · 2021-07-18T21:30:36Z

If we hard-coded the matrix, could we get more parallelism on the expensive builds?

we already have parallelism for the 4 expensive builds

OK! I must have been looking at something old that looked slower.

gonuke · 2021-07-18T21:31:43Z

I'll wait for CircleCI (should be OK) and then merge

gonuke · 2021-07-18T21:41:54Z

Thanks for tackling this @bam241

gonuke requested changes Jul 12, 2021

View reviewed changes

gonuke reviewed Jul 12, 2021

View reviewed changes

gonuke requested changes Jul 14, 2021

View reviewed changes

bam241 added 5 commits July 14, 2021 17:23

how about now?

d151547

no lapack :)

70b7a88

no blas either

ae15d20

fixing 20.04

fc0c43e

fixing ext deps file

92cc2ac

bam241 force-pushed the docker_test branch from bb3f168 to 92cc2ac Compare July 14, 2021 22:23

bam241 added 4 commits July 14, 2021 17:38

fixing repo name

31a984c

that should be better

58209d3

need ARG...

a00bf1d

how about now ?

c0fb641

bam241 force-pushed the docker_test branch from 3933530 to c0fb641 Compare July 15, 2021 13:41

bam241 added 4 commits July 15, 2021 08:44

how about now ?

9b359c5

how about now ?

d605d55

how about now ?

d5718ed

revert to normal pushes

d693af7

bam241 closed this Jul 15, 2021

bam241 added 7 commits July 15, 2021 11:43

how about now?

b657e82

we want svalinn

587945b

that shoudl do it

620fbd7

no login

cd0b3b3

now ?

d0bd976

how about now ?

2106121

what is in there ?

5decd6c

bam241 added 4 commits July 16, 2021 14:50

fixing name in moab docker img

32ce732

adding names to jobs and allow retaging on my username to test that's…

288be6f

… working well..

shorter names

d60ffa0

missing checkout

5bd19ee

gonuke requested changes Jul 17, 2021

View reviewed changes

CI/Dockerfile_3_moab Outdated Show resolved Hide resolved

Update CI/Dockerfile_3_moab

dabf4c8

Co-authored-by: Paul Wilson <paul.wilson@wisc.edu>

bam241 added 5 commits July 17, 2021 12:57

corrct ubuntu version

6104279

corrct ubuntu version

e482f96

Merge branch 'docker_test' of github.com:bam241/dagmc into docker_test

11d7476

no /root/build_dir/ necessary

ccff0a2

this should do it

71859d6

gonuke requested changes Jul 18, 2021

View reviewed changes

.github/workflows/docker_publish.yml Outdated Show resolved Hide resolved

bam241 and others added 4 commits July 18, 2021 08:40

Update .github/workflows/docker_publish.yml

04270a0

Co-authored-by: Paul Wilson <paul.wilson@wisc.edu>

missing the re-tagging

338e94d

Merge branch 'docker_test' of github.com:bam241/dagmc into docker_test

3e2feaa

resetting circle file and condition for retagging

f9ea14a

bam241 added 2 commits July 18, 2021 16:22

correct news name

e77913e

update news

018079b

gonuke approved these changes Jul 18, 2021

View reviewed changes

gonuke merged commit 2767342 into svalinn:develop Jul 18, 2021

bam241 deleted the docker_test branch November 28, 2024 14:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

integration of test for dockerfile update #754

integration of test for dockerfile update #754

bam241 commented Jul 12, 2021

bam241 commented Jul 12, 2021

bam241 commented Jul 12, 2021

shimwell commented Jul 12, 2021 •

edited

Loading

gonuke Jul 12, 2021

gonuke Jul 12, 2021

gonuke left a comment

gonuke Jul 14, 2021

bam241 commented Jul 15, 2021

gonuke left a comment

bam241 commented Jul 17, 2021

bam241 commented Jul 17, 2021

gonuke left a comment

gonuke commented Jul 18, 2021

bam241 commented Jul 18, 2021

bam241 commented Jul 18, 2021

bam241 commented Jul 18, 2021

gonuke commented Jul 18, 2021

gonuke commented Jul 18, 2021

gonuke commented Jul 18, 2021

integration of test for dockerfile update #754

integration of test for dockerfile update #754

Conversation

bam241 commented Jul 12, 2021

bam241 commented Jul 12, 2021

bam241 commented Jul 12, 2021

shimwell commented Jul 12, 2021 • edited Loading

gonuke Jul 12, 2021

Choose a reason for hiding this comment

gonuke Jul 12, 2021

Choose a reason for hiding this comment

gonuke left a comment

Choose a reason for hiding this comment

gonuke Jul 14, 2021

Choose a reason for hiding this comment

bam241 commented Jul 15, 2021

gonuke left a comment

Choose a reason for hiding this comment

bam241 commented Jul 17, 2021

bam241 commented Jul 17, 2021

gonuke left a comment

Choose a reason for hiding this comment

gonuke commented Jul 18, 2021

bam241 commented Jul 18, 2021

bam241 commented Jul 18, 2021

bam241 commented Jul 18, 2021

gonuke commented Jul 18, 2021

gonuke commented Jul 18, 2021

gonuke commented Jul 18, 2021

shimwell commented Jul 12, 2021 •

edited

Loading