Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac ci #780

Merged
merged 36 commits into from
Aug 22, 2021
Merged

Mac ci #780

merged 36 commits into from
Aug 22, 2021

Conversation

bam241
Copy link
Member

@bam241 bam241 commented Aug 20, 2021

first attempt to setup MACOS CI

@gonuke
Copy link
Member

gonuke commented Aug 21, 2021

Maybe start with the build strategy in the condo-forge Moab-feedstock? (Just a thought)

Copy link
Member

@gonuke gonuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sorting this out @bam241 - a little change for consitency

.github/workflows/mac_build_test.yml Outdated Show resolved Hide resolved
bam241 and others added 2 commits August 22, 2021 16:02
@bam241 bam241 marked this pull request as ready for review August 22, 2021 14:09
@gonuke
Copy link
Member

gonuke commented Aug 22, 2021

Thanks for the quick work here @bam241. I'm merging this first because the rebase will probably be simpler this way around

@gonuke gonuke merged commit 7bc70a1 into svalinn:develop Aug 22, 2021
@pshriwise
Copy link
Member

pshriwise commented Aug 22, 2021

Thanks for tracking down the cause of the problem here @bam241! Sorry for not including that header initially.

@bam241 bam241 deleted the mac_CI branch November 28, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants