-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding safe folder to allow CI to compile DAGMC #816
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested using the ${GITHUB_WORKSPACE}
variable instead
Co-authored-by: Paul Wilson <paul.wilson@wisc.edu>
Judging from the action logs in your account, I don't think this works. I think it needs to be added with a |
Rerunning the docker build CI on my fork https://github.com/shimwell/DAGMC/actions/runs/2672087279 |
Looks like there is another error while compiling moab in the docker file.
|
I think the root problem occurred before:
I think we need to declare as safe both the build dir and the install dir. |
Looks like the latest error is due to PyMoab being installed into a folder that is not in the PYTHONPATH and also the PYTHONPATH is empty 👀 https://github.com/shimwell/DAGMC/runs/7362738426?check_suite_focus=true |
I guess that didn't work - Maybe try the 5.3.2 release candidate now? |
update PYTHONPATH
Looks like adding the PYTHONPATH resulted in the dockerfiles building Nice work @bam241 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While the addition of the PYTHONPATH
allows it to work, I'm dubious of whether it's the 100% correct solution. Maybe it's temporary until we untangle the other parts of the build process?
@@ -80,6 +80,8 @@ RUN /root/etc/CI/docker/build_hdf5.sh | |||
|
|||
FROM hdf5 AS moab | |||
|
|||
ENV PYTHONPATH=/root/build_dir/moab/bld/pymoab/lib/python3.6/site-packages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes me wonder if we are installing MOAB in the wrong place? Or not installing it at all? Or we are installing it in the right place and we should reference that place here instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could add a python import command to the dockerfile to see if it is found by python if that helps check it it was installed
python -c "import pymoab"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem does not come from us.
It comes from Moab.
when they build and install pymoab
they install it locally with pip -e
for testing purposes
The problem is this is prevented because /root/build_dir/moab/bld/pymoab/lib/python3.6/site-packages
is not in our PYTHONPATH
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm… maybe the problem is that line 91 in the pymoab CMake is commented out?!?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like @pshriwise commented this out in 2018 🤣
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow that survived a long time
Thanks @shimwell - we'll go with this pending a future change in MOAB |
Description
Attempt to fix the CI that builds and publishes the docker images
Motivation and Context
Why is this change required? What problem does it solve?
The latest action to publish the docker image failed with this error message
https://github.com/svalinn/DAGMC/actions/runs/2637740871
This PR adds the folder to the safe directory folders
Changes
bug fix
Behavior
What is the current behavior? What is the new behavior?
broken CI - hopefully a fixed CI (I can't be sure as file owership issues in the CI can't be fully reproduced)