Graveyard updates #855
Merged
Graveyard updates #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the bounding box using vertex coords.
gonuke
requested changes
Feb 13, 2023
There was a problem hiding this comment.
Thanks @pshriwise - just a couple of maintainability questions
pshriwise
force-pushed
the
graveyard_updates
branch
from
6336330 to
0a53e2a
Compare
|
Should we ever replace an existing graveyard? Should we just not add another to the set? |
I can see someone wanting to replace a spherical shell graveyard in case they're learning DAGMC and didn't realize how many triangles this might add to their model without having to re-tessellate the entire thing. Granted, some kind of utility program in the repo would be better than writing it yourself own, which is what they'd have to now. |
gonuke
approved these changes
Feb 16, 2023
|
I'm ready to merge but want to give @makeclean a chance to either withdraw or amplify his concern? |
gonuke
requested changes
Mar 21, 2023
Co-authored-by: Paul Wilson <paul.wilson@wisc.edu>
|
Thanks @pshriwise |
gonuke
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These changes update some behavior of the
DagMC::create/remove_graveyardfunction.create_graveyardcreate_graveyardcan now create a graveyard without acceleration data structures using the vertices of the model to create a bounding box as a basis for the graveyard volume.create_graveyardwill create an implicit complement if none exists so the graveyard volume can be inserted into the model topology correctly.create_graveyardwill only (re)construct acceleration data structures for the new graveyard volume and the implicit complement if these data structures were present when the method was initially called.remove_graveyardThere's a bug when calling
create_graveyardwithoverwrite == truewhen a graveyard is not present. Previously, this would fail when trying to remove a graveyard that isn't present. This adds a check at the beginning ofremove_graveyardto simply returnMB_SUCCESSif no graveyard is present.