Add dd on merge #898
Merged
Add dd on merge #898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A successful demonstration of this test is here, including the currently failing Double Down test. |
It's not clear whether we want to tag/push these docker images since their purpose was just to test against upstream dependencies. |
|
Makes sense. Thanks for clarifying! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a test with Double Down on merge.
Motivation and Context
We discovered after a recent PR was merged that it broke compatibility with Double Down. For the time being, we have decided to only test that compatibility at merge and not with each PR.
Changes
Adds a matrix option to build DAGMC using Double Down. Also allows jobs to continue on error so that all options are tested even if one fails, since this is advisory post merge.
Also took the opportunity to collapse the docker builds in this workflow, and to exclude changes to this file from triggering other build/test actions.
Fixes #897