Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests on merge for various upstream packages #899

Merged
merged 21 commits into from
Aug 31, 2023

Conversation

gonuke
Copy link
Member

@gonuke gonuke commented Aug 21, 2023

Description

Create a set of separate tests that are run when a PR is merged to identify problems with upstream packages.

Motivation and Context

We rely on a number of upstream dependencies and currently pin their version to ensure success on our builds. It is useful, however, to monitor whether or not we break compatibility with an upstream or optional package due to changes in our code base or their code base.

Changes

Adds three new tests that only occur on merge. Badges for these tests are at the bottom of the readme for a quick assessment.

Because we are adding the ability to test multiple versions of Geant, this changes to embed the Geant version in the image name.

@gonuke
Copy link
Member Author

gonuke commented Aug 21, 2023

Evidence of docker images being built correctly here.

@gonuke
Copy link
Member Author

gonuke commented Aug 21, 2023

When merged, the following should be true:

@gonuke
Copy link
Member Author

gonuke commented Aug 21, 2023

Once merged, we'll need to update the linux build tests for the new image names, in a separate PR.

@gonuke gonuke requested review from pshriwise and shimwell August 21, 2023 13:09
@gonuke
Copy link
Member Author

gonuke commented Aug 30, 2023

Any chance that @shimwell or @pshriwise can give this a quick look over before tomorrow's call?

@shimwell
Copy link
Member

Just reading up on composite actions which are new to me but I have managed to looked over this in time for the call

Copy link
Member

@pshriwise pshriwise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for the explanation during the community meeting today @gonuke! I like these composite actions. I'll likely refer to this PR when trying them in the future.

@pshriwise pshriwise merged commit a7d1f3f into svalinn:develop Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants