Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: short description for each add-on #299

Merged
merged 7 commits into from
Nov 22, 2024
Merged

feat: short description for each add-on #299

merged 7 commits into from
Nov 22, 2024

Conversation

benmccann
Copy link
Member

@benmccann benmccann commented Nov 13, 2024

closes #297
closes #247

I've seen this feedback a number of times now, so think it's worth doing something here if we can keep the design clean enough

Screenshot from 2024-11-13 09-39-37

Copy link

changeset-bot bot commented Nov 13, 2024

🦋 Changeset detected

Latest commit: 322110d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
sv Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Nov 13, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/sveltejs/cli/sv@299
pnpm add https://pkg.pr.new/sveltejs/cli/svelte-migrate@299

commit: 322110d

@AdrianGonz97
Copy link
Member

I don't know, #297 is the first time that I've seen a complaint relating to this. I'm also having a hard time finding any similar complaints when I search through the discord and reddit. Not sure if this is a real issue that people actually face

@manuel3108
Copy link
Member

Agree with @AdrianGonz97, haven't seen any feedback beside the one mentioned earlier

@benmccann
Copy link
Member Author

I don't know if I'm going to be able to go back and find them, but there is #253:

For some addons it's pretty obvious what they do, but for others a link or a description would be very helpful. For example, unless you already know what mdsvex is, you're unlikely to know that that's what you want to be able to use Markdown in your Svelte components.

That issue was referring to our docs, but it's just as true that we don't have a description in the CLI

And of course there have been lots of folks confused about the Lucia adder (e.g. #217, #189, on reddit, etc.). This would allow us to close #247 as well, by clarifying that it's the guide in the hint.

@manuel3108
Copy link
Member

Already forgot about the the lucia stuff, convinced.

@manuel3108
Copy link
Member

Rebasing basically resulted in rewrite. I hate merge conflicts!

@manuel3108 manuel3108 merged commit 7aa4f07 into main Nov 22, 2024
8 checks passed
@manuel3108 manuel3108 deleted the short-desc branch November 22, 2024 13:15
@github-actions github-actions bot mentioned this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

better add command Rename lucia adder to auth
4 participants