-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move create
into its own package
#8
Conversation
commit:
|
Will changes to |
If we apply it as a
yea, we've had trouble with this in the past and are avoiding semver ranges on most of our own dependencies that aren't bundled |
I'm find with moving Also, fwiw, neither @Conduitry nor myself are aware of any specific users actually calling |
Bundling gets a tad annoying when I think it's a bit easier and more convenient for us to go down the route of just having a dedicated package for this in an effort to avoid others having to download unnecessary dependencies (like all the heavy ast tooling) if they're forced to use
we use it directly for the Skeleton CLI - usage site |
I feel like it won't be a great experience for skeleton users that they won't get all the other setup questions. There's no way for them to setup testing, formatting, linting, etc. during initial project creation if create is a separate project that they call. Maybe the skeleton CLI should be an adder instead? |
ah, all good points. alrighty, I'll set it up to be bundled instead
edit 2: i've tweaked it such that
we definitely tried back when svelte-add was still using git submodules 😆 but yea, it would be better suited as a community adder once we've got that ready |
As others have suggest I would also prefer to have all the commands bundled into IIRC we intended to call the command Edit: Other than that everything looks good |
why |
I keep calling it |
I'm fine with both, we could actually also implement an alias just in case. Some references: Others use |
i think the svelte community is more used to |
I'll do a poll of the ambassadors to see if there's any clear naming preference |
create
into it's own packagecreate
into its own package
Yeah, I feel like we should probably avoid bundling it with |
This PR moves the template creation logic into it's own package
create
, rather than having it live directly in thesv
package. This will allow us to separately publish this package so that outsiders can use it's programmatic api via@svelte-cli/create
(without needing to have a direct dependency onsv
).After this is merged, we can start adding the commands and move it's usage into
sv init
(orsv create
), rather than its current form of emulating how it used to work insvelte-add
.