-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: indent/indentScript option #180
Conversation
Allows to configure whether the contents of <script> blocks should be indented a single tabstop or not. Defaults to true for back-compat.
Thank you for this PR! I made one comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A new config for prettier
with this rule disabledd should be added IMO. @ota-meshi
Normally, the fixture should be formatted. However, stylistic rule invalid tests and option tests may ignore the format. |
Did I misunderstand what you were saying? Are you talking about the shareable configuration provided by this plugin? |
@ota-meshi I mean add a new config in this plugin: |
Exactly. |
Yeah. I think we need a new shareable configuration, as you say. We can work on it with another PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
Allows for configuring whether the contents of
<script>
blocks should be indented a single tabstop or not. Defaults totrue
for back-compat.Fixes #155