-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add rule types #735
feat: add rule types #735
Conversation
🦋 Changeset detectedLatest commit: e0b8690 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR! I didn't know we could do that with type definitions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
Fixes #707
This PR deviates slightly from the original request; instead of supporting
eslint-define-config
, this directly augments ESLint'sLinter.FlatConfig
type:This relies on eslint-typegen.
I've added a new build script in order to preserve the comments in thisrule-types.d.ts
file sincetsconfig.build.json
removes them (if there's a better way to do this then please let me know).