-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add svelte/no-svelte-internal
rule
#749
Conversation
🦋 Changeset detectedLatest commit: 78887d5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
I need to wait #751 |
cf33e4c
to
75caee9
Compare
I forgot to write a document.😇 |
84eaf9b
to
1117dee
Compare
5db6114
to
0603998
Compare
Finished ~~ @ota-meshi |
}, | ||
create(context) { | ||
return { | ||
ImportDeclaration(node) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably also check export * from 'svelte/internal'
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't expect anyone to do that, but I think it would be even better if we also check import('svelte/internal')
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good! updated: fca148a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## eslint-plugin-svelte@2.39.0 ### Minor Changes - [#749](#749) [`da4d535`](da4d535) Thanks [@baseballyama](https://github.com/baseballyama)! - feat: add `svelte/no-svelte-internal` rule - [#758](#758) [`6ee50c8`](6ee50c8) Thanks [@ota-meshi](https://github.com/ota-meshi)! - feat: Update svelte-eslint-parser to 0.36 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
svelte/internal
is deprecated in Svelte 5 and will be removed in Svelte 6 according to our current plan.The Svelte compiler only compiles
.svelte
files and.svelte.[jt]s
files, so the compiler can not check normal.[jt]s
files. Therefore, the ESLint plugin checks this.