feat: add svelte/no-svelte-internal rule
#749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 78887d5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
I need to wait #751 |
baseballyama
force-pushed
the
feat/no-svelte-internal
branch
2 times, most recently
from
cf33e4c
to
75caee9
Compare
|
I forgot to write a document.😇 |
baseballyama
force-pushed
the
feat/no-svelte-internal
branch
from
84eaf9b
to
1117dee
Compare
baseballyama
force-pushed
the
feat/no-svelte-internal
branch
from
5db6114
to
0603998
Compare
|
Finished ~~ @ota-meshi |
ota-meshi
requested changes
May 9, 2024
| }, | ||
| create(context) { | ||
| return { | ||
| ImportDeclaration(node) { |
There was a problem hiding this comment.
We should probably also check export * from 'svelte/internal'.
There was a problem hiding this comment.
I don't expect anyone to do that, but I think it would be even better if we also check import('svelte/internal').
There was a problem hiding this comment.
Good! updated: fca148a
ota-meshi
pushed a commit
that referenced
this pull request
May 10, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## eslint-plugin-svelte@2.39.0 ### Minor Changes - [#749](#749) [`da4d535`](da4d535) Thanks [@baseballyama](https://github.com/baseballyama)! - feat: add `svelte/no-svelte-internal` rule - [#758](#758) [`6ee50c8`](6ee50c8) Thanks [@ota-meshi](https://github.com/ota-meshi)! - feat: Update svelte-eslint-parser to 0.36 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
svelte/internalis deprecated in Svelte 5 and will be removed in Svelte 6 according to our current plan.The Svelte compiler only compiles
.sveltefiles and.svelte.[jt]sfiles, so the compiler can not check normal.[jt]sfiles. Therefore, the ESLint plugin checks this.