Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: svelte/valid-compile to use verbatimModuleSyntax to work with TS v5.5. #797

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

ota-meshi
Copy link
Member

@ota-meshi ota-meshi commented Jun 17, 2024

See comment #790 (comment)

Copy link

changeset-bot bot commented Jun 17, 2024

🦋 Changeset detected

Latest commit: d9aa73f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@baseballyama baseballyama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I learned this option😅 and confirmed the behavior on TypeScript playground.

@ota-meshi ota-meshi merged commit f6d4e4c into main Jun 17, 2024
13 checks passed
@ota-meshi ota-meshi deleted the fix-valid-compile2 branch June 17, 2024 14:54
ota-meshi pushed a commit that referenced this pull request Jun 17, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## eslint-plugin-svelte@2.40.0

### Minor Changes

- [#792](#792)
[`cb722bc`](cb722bc)
Thanks [@ota-meshi](https://github.com/ota-meshi)! - feat: update
svelte-eslint-parser to 0.39

- [#796](#796)
[`5e4d264`](5e4d264)
Thanks [@ota-meshi](https://github.com/ota-meshi)! - feat: improve
`svelte/valid-compile` to use `svelte.config.js`'s `onwarn` from the
parser.

- [#794](#794)
[`7894f82`](7894f82)
Thanks [@ota-meshi](https://github.com/ota-meshi)! - feat: improve
`svelte/valid-prop-names-in-kit-pages` to use `svelte.config.js` data
from the parser.

- [#794](#794)
[`7894f82`](7894f82)
Thanks [@ota-meshi](https://github.com/ota-meshi)! - feat: improve
`svelte/no-export-load-in-svelte-module-in-kit-pages` to use
`svelte.config.js` data from the parser.

### Patch Changes

- [#795](#795)
[`df947a7`](df947a7)
Thanks [@baseballyama](https://github.com/baseballyama)! - deps: update
`svelte-eslint-parser` to 0.39.1 to set `svelteFeatures.runes` to `true`
by default for Svelte 5

- [#797](#797)
[`f6d4e4c`](f6d4e4c)
Thanks [@ota-meshi](https://github.com/ota-meshi)! - fix:
`svelte/valid-compile` to use verbatimModuleSyntax to work with TS v5.5.

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants