-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update svelte-eslint-parser
to fix nested {#snippet}
#805
Conversation
🦋 Changeset detectedLatest commit: 4f7a007 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
16d35d3
to
f282044
Compare
Hmm. The latest {#snippet
foo(
{
a
}
)
}
{/snippet}
{@render
foo(
{
a
}
)
} |
There seems to be no problem with 5.0.0-next.163. There may be a problem with the difference with 5.0.0-next.164. |
I haven't written a test case yet, so I'm not sure, but we may need to add the s flag to handle newline characters. - params += parser.read(/^./);
+ params += parser.read(/^./s); |
It seems to have been fixed already, we just need to wait for the next version release. |
.github/workflows/NodeCI.yml
Outdated
@@ -76,7 +76,9 @@ jobs: | |||
run: pnpm install -D -w eslint@${{ matrix.eslint }} | |||
|
|||
- name: Test | |||
run: pnpm test | |||
run: | | |||
export NODE_OPTIONS="--max-old-space-size=8192" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I expect this workaround will no longer be necessary once v5.0.0-165 is released.
Some issues were still not fixed, so I opened an issue in the svelte repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Everything works fine with the latest version of svelte/compiler.
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## eslint-plugin-svelte@2.41.0 ### Minor Changes - [#802](#802) [`be64d36`](be64d36) Thanks [@ota-meshi](https://github.com/ota-meshi)! - fix: broken indentation of if condition in `svelte/indent` rule ### Patch Changes - [#789](#789) [`0bc17df`](0bc17df) Thanks [@KuSh](https://github.com/KuSh)! - chore: Use eslint types for exported configs - [#805](#805) [`6e4d3ed`](6e4d3ed) Thanks [@baseballyama](https://github.com/baseballyama)! - fix: update `svelte-eslint-parser` to fix nested `{#snippet}` - [#800](#800) [`580f44f`](580f44f) Thanks [@ota-meshi](https://github.com/ota-meshi)! - feat: add name to flat configs. Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
No description provided.