-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(html-closing-bracket-new-line): add rule #870
feat(html-closing-bracket-new-line): add rule #870
Conversation
|
|
||
## :wrench: Options | ||
|
||
```jsonc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ota-meshi, jsonc
feels like the right lang to use, does it have any issue with the docs syntax highlighting?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the syntax highlighting works fine on our website 👍
8437533
to
157d6be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR! LGTM!
|
||
```jsonc | ||
{ | ||
"svelte/brackets-same-line": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be svelte/html-closing-bracket-new-line
?
|
||
```svelte | ||
<script> | ||
/* eslint svelte/brackets-same-line: "error" */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
svelte/html-closing-bracket-new-line
?
Correcting: - [Comment 1](#870 (comment)) - [Comment 2](#870 (comment)) Thanks to @noy4 for pointing the issues out.
Adds the
svelte/html-closing-bracket-newline
rule, which enforces that HTMLtags must have a newline (or not) after the closing bracket. This rule is
inspired by
vue/html-closing-bracket-newline
, and is implemented ensuringwhat's discussed in #590.
Closes #590.