fix: ensure search params are not left off of load_cache
#21928
Workflow file for this run
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| name: CI | |
| on: | |
| push: | |
| branches: | |
| - main | |
| pull_request: | |
| env: | |
| # we call `pnpm playwright install` instead | |
| PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: '1' | |
| # cancel in-progress runs on new commits to same PR (gitub.event.number) | |
| concurrency: | |
| group: ${{ github.workflow }}-${{ github.event.number || github.sha }} | |
| cancel-in-progress: true | |
| permissions: | |
| contents: read # to fetch code (actions/checkout) | |
| jobs: | |
| pkg-pr-new: | |
| runs-on: ubuntu-latest | |
| steps: | |
| - uses: actions/checkout@v4 | |
| - uses: pnpm/action-setup@v4.0.0 | |
| - uses: actions/setup-node@v4 | |
| with: | |
| node-version: 22 | |
| cache: pnpm | |
| - run: pnpm install --frozen-lockfile | |
| - run: pnpx pkg-pr-new publish --comment=off ./packages/kit | |
| lint-all: | |
| runs-on: ubuntu-latest | |
| steps: | |
| - uses: actions/checkout@v4 | |
| - uses: pnpm/action-setup@v4.0.0 | |
| - uses: actions/setup-node@v4 | |
| with: | |
| node-version: 22 | |
| cache: pnpm | |
| - run: pnpm install --frozen-lockfile | |
| - run: pnpm run lint | |
| - run: cd packages/kit && pnpm prepublishOnly && { [ "`git status --porcelain=v1`" == "" ] || (echo "Generated types have changed — please run prepublishOnly locally and commit the changes after you have reviewed them"; git diff; exit 1); } | |
| - run: pnpm run check | |
| test-kit: | |
| runs-on: ${{ matrix.os }} | |
| timeout-minutes: 30 | |
| strategy: | |
| fail-fast: false | |
| matrix: | |
| include: | |
| - node-version: 18 | |
| os: ubuntu-latest | |
| e2e-browser: 'chromium' | |
| - node-version: 20 | |
| os: ubuntu-latest | |
| e2e-browser: 'chromium' | |
| - node-version: 22 | |
| os: ubuntu-latest | |
| e2e-browser: 'chromium' | |
| env: | |
| KIT_E2E_BROWSER: ${{matrix.e2e-browser}} | |
| steps: | |
| - run: git config --global core.autocrlf false | |
| - uses: actions/checkout@v4 | |
| - uses: pnpm/action-setup@v4.0.0 | |
| - uses: actions/setup-node@v4 | |
| with: | |
| node-version: ${{ matrix.node-version }} | |
| cache: pnpm | |
| - run: pnpm install --frozen-lockfile | |
| - run: pnpm playwright install ${{ matrix.e2e-browser }} | |
| - run: pnpm run sync-all | |
| - run: pnpm test:kit | |
| - name: Print flaky test report | |
| run: node scripts/print-flaky-test-report.js | |
| - name: Archive test results | |
| if: failure() | |
| shell: bash | |
| run: find packages -type d -name test-results -not -empty | tar -czf test-results.tar.gz --files-from=- | |
| - name: Upload test results | |
| if: failure() | |
| uses: actions/upload-artifact@v4 | |
| with: | |
| retention-days: 3 | |
| name: test-failure-${{ github.run_id }}-${{ matrix.os }}-${{ matrix.node-version }}-${{ matrix.e2e-browser }} | |
| path: test-results.tar.gz | |
| test-kit-cross-browser: | |
| runs-on: ${{ matrix.os }} | |
| timeout-minutes: 30 | |
| strategy: | |
| fail-fast: false | |
| matrix: | |
| include: | |
| - node-version: 18 | |
| os: windows-2019 # slowness reported on newer versions https://github.com/actions/runner-images/issues/5166 | |
| e2e-browser: 'chromium' | |
| mode: 'dev' | |
| - node-version: 18 | |
| os: ubuntu-latest | |
| e2e-browser: 'firefox' | |
| mode: 'dev' | |
| - node-version: 18 | |
| os: macOS-latest | |
| e2e-browser: 'webkit' | |
| mode: 'dev' | |
| - node-version: 18 | |
| os: windows-2019 # slowness reported on newer versions https://github.com/actions/runner-images/issues/5166 | |
| e2e-browser: 'chromium' | |
| mode: 'build' | |
| - node-version: 18 | |
| os: ubuntu-latest | |
| e2e-browser: 'firefox' | |
| mode: 'build' | |
| - node-version: 18 | |
| os: macOS-latest | |
| e2e-browser: 'webkit' | |
| mode: 'build' | |
| env: | |
| KIT_E2E_BROWSER: ${{matrix.e2e-browser}} | |
| steps: | |
| - run: git config --global core.autocrlf false | |
| - uses: actions/checkout@v4 | |
| - uses: pnpm/action-setup@v4.0.0 | |
| - uses: actions/setup-node@v4 | |
| with: | |
| node-version: ${{ matrix.node-version }} | |
| cache: pnpm | |
| - run: pnpm install --frozen-lockfile | |
| - run: pnpm playwright install ${{ matrix.e2e-browser }} | |
| - run: pnpm run sync-all | |
| - run: pnpm test:cross-platform:${{ matrix.mode }} | |
| - name: Print flaky test report | |
| run: node scripts/print-flaky-test-report.js | |
| - name: Archive test results | |
| if: failure() | |
| shell: bash | |
| run: find packages -type d -name test-results -not -empty | tar -czf test-results-cross-platform-${{ matrix.mode }}.tar.gz --files-from=- | |
| - name: Upload test results | |
| if: failure() | |
| uses: actions/upload-artifact@v4 | |
| with: | |
| retention-days: 3 | |
| name: test-failure-cross-platform-${{ matrix.mode }}-${{ github.run_id }}-${{ matrix.os }}-${{ matrix.node-version }}-${{ matrix.e2e-browser }} | |
| path: test-results-cross-platform-${{ matrix.mode }}.tar.gz | |
| test-others: | |
| runs-on: ubuntu-latest | |
| steps: | |
| - uses: actions/checkout@v4 | |
| - uses: pnpm/action-setup@v4.0.0 | |
| - uses: actions/setup-node@v4 | |
| with: | |
| node-version: 18 | |
| cache: pnpm | |
| - run: pnpm install --frozen-lockfile | |
| - run: pnpm playwright install chromium | |
| - run: cd packages/kit && pnpm prepublishOnly | |
| - run: pnpm run test:others |