ignore mailto: links etc (#2915)

* ignore hrefs with a scheme - fixes #2909 * changeset
sveltejs · Nov 25, 2021 · 3365f0b · 3365f0b
1 parent cf3a8b5
commit 3365f0b
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 0 deletions.
diff --git a/.changeset/proud-numbers-promise.md b/.changeset/proud-numbers-promise.md
@@ -0,0 +1,5 @@
+---
+'@sveltejs/kit': patch
+---
+
+Ignore mailto: and tel: links
diff --git a/packages/kit/src/utils/url.js b/packages/kit/src/utils/url.js
@@ -1,10 +1,13 @@
 const absolute = /^([a-z]+:)?\/?\//;
+const scheme = /^[a-z]+:/;
 
 /**
  * @param {string} base
  * @param {string} path
  */
 export function resolve(base, path) {
+	if (scheme.test(path)) return path;
+
 	const base_match = absolute.exec(base);
 	const path_match = absolute.exec(path);
 

diff --git a/packages/kit/src/utils/url.spec.js b/packages/kit/src/utils/url.spec.js
@@ -46,4 +46,8 @@ test('resolves an absolute path', () => {
 	assert.equal(resolve('/a/b/c', 'https://example.com/foo'), 'https://example.com/foo');
 });
 
+test('handles schemes like tel: and mailto:', () => {
+	assert.equal(resolve('/a/b/c', 'mailto:hello@svelte.dev'), 'mailto:hello@svelte.dev');
+});
+
 test.run();