fix git mv commands when migrating files with $ characters (#6129)

* use single-quote to avoid $ characters wreaking havoc - fixes #6113 * changeset * use shell-quote package * do this instead
sveltejs · Aug 20, 2022 · 7eb78a5 · 7eb78a5
1 parent 7ec22e2
commit 7eb78a5
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/.changeset/unlucky-cameras-appear.md b/.changeset/unlucky-cameras-appear.md
@@ -0,0 +1,5 @@
+---
+'svelte-migrate': patch
+---
+
+[fix] git mv files correctly when they contain \$ characters
diff --git a/packages/migrate/migrations/routes/utils.js b/packages/migrate/migrations/routes/utils.js
@@ -3,7 +3,7 @@ import path from 'path';
 import colors from 'kleur';
 import ts from 'typescript';
 import MagicString from 'magic-string';
-import { execSync } from 'child_process';
+import { execFileSync } from 'child_process';
 
 /** @param {string} message */
 export function bail(message) {
@@ -46,7 +46,7 @@ export function error(description, comment_id) {
  */
 export function move_file(file, renamed, content, use_git) {
 	if (use_git) {
-		execSync(`git mv ${JSON.stringify(file)} ${JSON.stringify(renamed)}`);
+		execFileSync('git', ['mv', file, renamed]);
 	} else {
 		fs.unlinkSync(file);
 	}